Skip to content

[FIX]: Fails for parallel test - #49

Merged
aaronj0 merged 1 commit into
compiler-research:mainfrom
keremsahn:xdist-fails
Aug 30, 2026
Merged

[FIX]: Fails for parallel test#49
aaronj0 merged 1 commit into
compiler-research:mainfrom
keremsahn:xdist-fails

Conversation

@keremsahn

Copy link
Copy Markdown
Contributor

I solved the causes described in #47
@Vipul-Cariappa @aaronj0

@aaronj0

aaronj0 commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

I think these changes are already a part of ongoing test-revamp in this branch: https://github.com/compiler-research/cppjit/tree/test-suite-infra, but we can land this independently. Thanks.

@aaronj0 aaronj0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@aaronj0
aaronj0 merged commit 133da28 into compiler-research:main Aug 30, 2026
9 checks passed
@vgvassilev

Copy link
Copy Markdown
Contributor

Can you explain how this change resolved the parallelism problems?

@aaronj0

aaronj0 commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Can you explain how this change resolved the parallelism problems?

test09_templated_function (TestTUTORIALFEATURES) relied on another class (TestDOCFEATURES) to cppdef multiply introducing an inter-test setup dependency.

test03_memory never imported ll itself making the module unreachable unless the same worker happened to have an earlier test that did so.

This change was already tested with 87e799c

@keremsahn

keremsahn commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

Can you explain how this change resolved the parallelism problems?

The first change was just a definition replacement, I just moved the definition of multiply function, where it is actually used.

In the second I just added import ll, the test was using ll but was not importing it, so it was dependent on previous tests' import, so it was failing sometimes in parallel mode

@vgvassilev

Copy link
Copy Markdown
Contributor

Ok, thanks -- in retrospect, probably worth being part of the commit message.

vgvassilev pushed a commit to vgvassilev/cppjit that referenced this pull request Sep 6, 2026
Changed definition of a function to the test it is actually used, and added a missing import
aaronj0 pushed a commit to aaronj0/cppjit-compres that referenced this pull request Sep 6, 2026
Changed definition of a function to the test it is actually used, and added a missing import
aaronj0 pushed a commit to aaronj0/cppjit-compres that referenced this pull request Sep 6, 2026
Changed definition of a function to the test it is actually used, and added a missing import
aaronj0 pushed a commit to aaronj0/cppjit-compres that referenced this pull request Sep 6, 2026
Changed definition of a function to the test it is actually used, and added a missing import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants