[FIX]: Fails for parallel test - #49
Conversation
… added a missing import
|
I think these changes are already a part of ongoing test-revamp in this branch: https://github.com/compiler-research/cppjit/tree/test-suite-infra, but we can land this independently. Thanks. |
|
Can you explain how this change resolved the parallelism problems? |
This change was already tested with 87e799c |
The first change was just a definition replacement, I just moved the definition of multiply function, where it is actually used. In the second I just added import ll, the test was using ll but was not importing it, so it was dependent on previous tests' import, so it was failing sometimes in parallel mode |
|
Ok, thanks -- in retrospect, probably worth being part of the commit message. |
Changed definition of a function to the test it is actually used, and added a missing import
Changed definition of a function to the test it is actually used, and added a missing import
Changed definition of a function to the test it is actually used, and added a missing import
Changed definition of a function to the test it is actually used, and added a missing import
I solved the causes described in #47
@Vipul-Cariappa @aaronj0